Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix typo in parameters/index.ipynb #3100

Closed
wants to merge 2 commits into from

Conversation

codingonion
Copy link

No description provided.

Signed-off-by: codingonion <coderonion@gmail.com>
@codingonion codingonion requested a review from a team as a code owner June 22, 2024 02:34
Copy link
Collaborator

@arthurevans arthurevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I've edited the copy a little bit.

docs/manual/parameters/index.ipynb Outdated Show resolved Hide resolved
Signed-off-by: Arthur Evans <arthur@modular.com>
@arthurevans
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Jun 24, 2024
@modularbot
Copy link
Collaborator

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

@modularbot modularbot added merged-internally Indicates that this pull request has been merged internally merged-externally Merged externally in public mojo repo labels Jun 24, 2024
modularbot pushed a commit that referenced this pull request Jun 25, 2024
[External] [docs] Fix typo in parameters/index.ipynb

Co-authored-by: codingonion <coderonion@gmail.com>
Closes #3100
MODULAR_ORIG_COMMIT_REV_ID: 587f20d2163d775c16092a7a458a146de0f2fb55
@modularbot
Copy link
Collaborator

Landed in a592d81! Thank you for your contribution 🎉

@modularbot modularbot closed this Jun 25, 2024
@codingonion codingonion deleted the my-fix-pr branch June 26, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported-internally Signals that a given pull request has been imported internally. merged-externally Merged externally in public mojo repo merged-internally Indicates that this pull request has been merged internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants