feat: Unify Federation with ModernJS & Byte Infra team #1268
+2,699
−10,303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2heal1
reviewed
Aug 30, 2023
ScriptedAlchemy
commented
Sep 1, 2023
| set.add(RuntimeGlobals.moduleFactoriesAddOnly); | ||
| set.add(RuntimeGlobals.hasOwnProperty); | ||
|
|
||
| set.add(RuntimeGlobals.publicPath); |
There was a problem hiding this comment.
This causes import.meta which breaks node auto path
There was a problem hiding this comment.
@2heal1 I think it's this which breaks other pr where public path is auto.
…mprove_auto_public_path # Conflicts: # packages/node/src/plugins/FederationModuleInfoRuntimeModule.ts # packages/node/src/plugins/RemotePublicPathRuntimeModule.js # packages/node/src/plugins/loadScript.ts
…nction This commit enhances the readability of the httpVmStrategy by providing comprehensive inline documentation. The comments explain the purpose of the function, its parameters, and what it does. This will aid future developers in understanding the purpose and usage of the httpVmStrategy function. ### packages/node/src/filesystem/stratagies.js - Added comprehensive inline documentation for the httpVmStrategy function
Refactoring and Enhancements of Node Federation Plugin and Filesystem Strategy, Including Addition of New Features and Tests
This commit includes refactoring of DelegateModulesPlugin.ts. Changes involve updating data structures, adjusting logic for handling modules and dependencies and moving the resolveDelegateModules functionality in the apply method. ### packages/utilities/src/plugins/DelegateModulesPlugin.ts - changed Set data structure of _delegateModules to Map - adjusted logic to handle modules and dependencies using forEach instead of looping with 'for' keyword - replaced 'set' with 'add' keyword to add modules to _delegateModules - moved resolveDelegateModules functionality inside the apply method
# Conflicts: # package-lock.json # package.json # packages/nextjs-mf/src/default-delegate.ts # packages/node/src/plugins/CommonJsChunkLoadingPlugin.ts # packages/node/src/plugins/LoadFileChunkLoadingRuntimeModule.ts # packages/utilities/src/plugins/DelegateModulesPlugin.ts
… (#node_auto_public_path)
…ublic_path) Updated DelegateModulesPlugin to use 'const' in for-of loops and added 'thisCompilation' hook. Adjusted test cases to reflect these changes. Also, updated DynamicFilesystemRuntimeModule to remove unused 'RuntimeGlobals' import.
…ts (#node_auto_public_path) Removed unutilized 'importMetaName' from RemotePublicPathRuntimeModule. Updated NodeFederationPlugin.parseRemotes.test.js to reflect changes in global and remote scope naming conventions.
…_public_path Enable webpack devMiddleware to write to disk in development mode. This allows developers to view and debug the output files generated by webpack during development.
…ic_path) This commit adds support for automatically setting the public path for remote modules. This feature allows for dynamic path resolution based on the publicPath value in the outputOptions of the webpack configuration. If the publicPath value is set to "auto", the path is automatically resolved, otherwise, the static value of publicPath is used. This change provides more flexibility in setting the public path for remote modules.
…node_auto_public_path Updated CommonJsChunkLoadingPlugin to automatically set the public path from options instead of using a constant value. Also enhanced the chunk loading strategy to provide better logging and fallback options in scenarios where the chunk load fails. This will improve the maintainability and debugging of chunk loading processes.
# Conflicts: # package-lock.json # package.json # packages/node/src/plugins/CommonJsChunkLoadingPlugin.ts # packages/node/src/plugins/LoadFileChunkLoadingRuntimeModule.ts
…unkCorrelationPlugin.js (#bytedance)
…r code (#bytedance)
…oRuntimeModule (#bytedance)
…edance) The createDelegatedModule utility from the nextjs-mf package was commented out, indicating no longer necessary for the checkout app's next.config.js. Also, a jest environment was added to the eslint configuration in the node package, and the generated comments and ts-ignore directives were removed from the test file for parseRemotes in the NodeFederationPlugin.
# Conflicts: # package-lock.json # packages/node/.eslintrc.json # packages/node/src/plugins/FederationModuleInfoRuntimeModule.ts # packages/node/src/plugins/NodeFederationPlugin.parseRemotes.test.js
This was referenced Sep 29, 2023
Closed
Closed
…ytedance-ImportRequire Enhanced - remove import require statements for swc interop
|
🎉 This PR is included in version 8.1.0-canary.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.1.0-canary.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0-canary.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0-canary.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0-canary.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Infra Team has implemented substantial improvements to federation internally.
While the node plugin is still WIP, this is the beginning of unifying our ecosystems.
update: Since initial commits, this has evolved. As we plan to implement node federation into rspack natively. We have gotten some guidance on how to design a dynamic fileystem in a non-hacky manner. So this now includes:
Update:
This PR has grown in scope