Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esbuild): Esbuild support #2473

Merged
merged 49 commits into from
Jun 27, 2024
Merged

feat(esbuild): Esbuild support #2473

merged 49 commits into from
Jun 27, 2024

Conversation

ScriptedAlchemy
Copy link
Member

@ScriptedAlchemy ScriptedAlchemy commented May 10, 2024

Description

Module Federation implementation for Esbuild

More work to be done.

  • Replace runtime with module-federation/runtime
  • implement remotes in build plugin
  • implement passthrough of build config
  • create module proxies during build

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented May 10, 2024

🦋 Changeset detected

Latest commit: d526266

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@module-federation/esbuild Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented May 10, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit d526266
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/667db110a389530008597b0b
😎 Deploy Preview https://deploy-preview-2473--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ScriptedAlchemy ScriptedAlchemy changed the title feat(esbuild): Esbuild support WIP: feat(esbuild): Esbuild support May 10, 2024
Co-authored-by: ScriptedAlchemy <zackaryjackson@bytedance.com>
Comment on lines +221 to +223
`var ${name} = /* @__PURE__ */ (() => exports[${JSON.stringify(
e,
)}])();`,

Check warning

Code scanning / CodeQL

Improper code sanitization Medium

Code construction depends on an
improperly sanitized value
.
@ScriptedAlchemy ScriptedAlchemy changed the title WIP: feat(esbuild): Esbuild support feat(esbuild): Esbuild support Jun 25, 2024
@ScriptedAlchemy ScriptedAlchemy marked this pull request as ready for review June 27, 2024 01:04
@ScriptedAlchemy ScriptedAlchemy merged commit 99ecb31 into main Jun 27, 2024
9 checks passed
@ScriptedAlchemy ScriptedAlchemy deleted the feat/esbuild branch June 27, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant