Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add enable cache buster #467

Merged
merged 4 commits into from
Sep 13, 2023
Merged

feat: add enable cache buster #467

merged 4 commits into from
Sep 13, 2023

Conversation

nattaaek
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 39f879b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 12, 2023

Someone is attempting to deploy a commit to the Module Federation Team on Vercel.

A member of the Team first needs to authorize it.

edusperoni
edusperoni suggested changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@edusperoni edusperoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thanks for this. I've added some comments to keep the code consistent

dashboard-plugin/client-version.js Outdated Show resolved Hide resolved
dashboard-plugin/client-version.js Outdated Show resolved Hide resolved
dashboard-plugin/client-version.js Outdated Show resolved Hide resolved
dashboard-plugin/client-version.js Outdated Show resolved Hide resolved
dashboard-plugin/client-version.js Outdated Show resolved Hide resolved
dashboard-plugin/client-version.js Outdated Show resolved Hide resolved
@nattaaek nattaaek changed the title [feature] - add enable cache buster feat: add enable cache buster Sep 12, 2023
@valorkin valorkin merged commit 941643a into module-federation:master Sep 13, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valorkin valorkin valorkin approved these changes

@edusperoni edusperoni edusperoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nattaaek @valorkin @edusperoni