Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add enable cache buster #467

Merged
merged 4 commits into from
Sep 13, 2023
Merged

feat: add enable cache buster #467

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
191d325
[feature] - add enable cache buster
Sep 12, 2023
0429d54
Update client-version.js
nattaaek Sep 12, 2023
07472fb
typo and remove comment
nattaaek Sep 12, 2023
39f879b
fix indent to make it same as before
nattaaek Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions dashboard-plugin/client-version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@ module.exports = ({
fallbackEntryURL,
fallbackRemoteVar,
dashboardTimeout,
fallbackEnableCacheBuster,
}) => {
fallbackRemoteVar = fallbackRemoteVar || remoteName;
fallbackEntryURL = fallbackEntryURL || '';
fallbackEnableCacheBuster = fallbackEnableCacheBuster || false;
if (!dashboardTimeout) {
dashboardTimeout = -1;
}
Expand Down Expand Up @@ -75,6 +77,11 @@ module.exports = ({
if (!fallbackEntryURL) return Promise.reject(error);
var name = '${fallbackRemoteVar}';
var url = new URL(fallbackEntryURL);

if (${fallbackEnableCacheBuster}) {
var cacheBuster = Date.now();
url.searchParams.append('cacheBuster', cacheBuster);
}

new Promise(function (resolve, reject) {
var __webpack_error__ = new Error();
Expand Down