Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better handling of style attribute #22

Closed
nogizhopaboroda opened this issue Mar 22, 2018 · 1 comment · Fixed by #24
Closed

better handling of style attribute #22

nogizhopaboroda opened this issue Mar 22, 2018 · 1 comment · Fixed by #24
Labels
bug Something isn't working

Comments

@nogizhopaboroda
Copy link
Member

come up with better solution for handling style attribute.
reasons:

  1. breaks old versions of safari
  2. it should not be set as string

simplest solution could be to set it as normal attribute.
@nogizhopaboroda nogizhopaboroda added the bug Something isn't working label Mar 22, 2018
@nogizhopaboroda nogizhopaboroda mentioned this issue Mar 28, 2018
Merged
@nogizhopaboroda
Copy link
Member Author

fixed in #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(setAttribute): set style as regular attribute modulor-js/modulor-html
1 participant
@nogizhopaboroda