Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed method getProductKey so that it takes into account product options #846

Merged
merged 1 commit into from
Apr 9, 2023

Conversation

Semdevmaster
Copy link
Contributor

Что оно делает?

Исправляет метод формирования ключа товара в корзине, чтобы он учитывал стандартные опции товара

@Alexij2
Copy link
Contributor

Alexij2 commented Apr 9, 2023

Проверил тоже. Вроде работает.
Но вопрос еще. Зачем проверять то что поле принадлежит ресурсу, раз оно совершенно не повлияет на добавление в корзину? Те я не вижу смысла в методе getProductKey.

@biz87 biz87 self-requested a review April 9, 2023 10:38
@biz87 biz87 merged commit 08874da into modx-pro:master Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants