PSR-3 Logging #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This recommendation is now ready for formal review and vote as far as I'm concerned. |
|
Started to play around a little bit with code for this. Getting this properly implemented will depending on the DIC (#12) as the logger and configuration for it should be retrieved from that (or a config file of sorts), but https://github.com/modxcms/revolution/compare/3.x...Mark-H:psr3?expand=1 is a functional implementation of PSR3/monolog into MODX 3, if anyone wants to give it a go. |
|
👍 |
10 similar comments
|
👍 |
|
👍 |
|
👍 |
|
👍
|
|
👍 |
|
👍 |
|
👍 |
|
👍 |
|
👍 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second draft of the PSR-3 Logging Recommendation, first shared via Google Drive in October. Slightly updated text, however requires a bit more editing before putting it to a formal review/vote. Feedback is of course welcome.