Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendation about CLI tool #9

Closed
wants to merge 1 commit into from
Closed

Conversation

rtripault
Copy link
Collaborator

No description provided.

@rtripault rtripault changed the title [Draft] Recommendation about CLI tool [DRAFT] Recommendation about CLI tool Nov 23, 2016
@Mark-H Mark-H added the Draft label Nov 24, 2016
@christianseel christianseel changed the title [DRAFT] Recommendation about CLI tool Recommendation about CLI tool Nov 24, 2016
@Mark-H
Copy link
Collaborator

Mark-H commented Nov 29, 2016

I suppose this might be a question to the rest of the board as well, but how detailed do we want the recommendations to be? This recommendation mentions a lot of examples, but doesn't mention specifically what should be available in a MODX CLI tool.

Personally I'm starting to think that it should be possible to assess (somewhat) objectively if a recommendation is implemented fully, for it to be most useful. I.e. it needs to have a clear path to action and completion.

For example Jason's Slim 3 recommendation is complete when MODX is refactored to be built on Slim 3 and JPs Accessible Setup is implemented when the setup provides accessibility options and an extra can register things to it. But when is this recommendation "done": if one item in the list of examples is implemented, or all of them?

Or am I alone in looking for recommendations to be actionable with a finish line? If so I'm happy to adapt ;) Sorry if I'm being perhaps a bit too critical of the draft recommendations, just trying to figure out how we want to about things like this.

@jpdevries
Copy link
Collaborator

jpdevries commented Nov 29, 2016

I ❤️ the idea of a CLI tool especially if it would let you update Extras (or whatever we call them now)

we could call it MPM 😆

@rtripault
Copy link
Collaborator Author

I'm not sure either how "generic" or technically agnostic we should be (the MAB is pretty new, let's allow some failure/trial ^^).

However, as a "technical guy", i would love them being some more closer to some kind of specs.

About this particular recommendation, i could consider it fulfilled if the following is "shipped"

  • Developers should be able to ship their custom build commands (with their extras/components or independently) (line 15)
  • install the CMS, upgrade the CMS, install components/extras (line 18)

Also, keep in mind this is a draft, which, at least from my seat, is rather a request for comment(s) than anything else.

Sorry if I'm being perhaps a bit too critical of the draft recommendations

Please don't (at least for mine), as you wrote, we need to figure out how we will work best (for ourselves, the product and the community)!

@jpdevries
Copy link
Collaborator

Not only is a CLI great for 🤓 power users but it is a great accessibility consideration for keyboard users! I try to "count the clicks" when creating interfaces. This could save a ton of clicks.

@gpsietzema
Copy link
Collaborator

@rtripault Have you already done any coding for this? There is a working group at Sterc working on some own internal stuff for this, which might also come in handy for this recommendation and we don't want to write stuff which is already there.

@Jako
Copy link
Collaborator

Jako commented Jan 11, 2017

@gpsietzema https://github.com/OptimusCrime/modx-cli has done some initial work on something similar. Maybe you could contact him. And this one exists https://github.com/meltingmedia/MODX-Shell

@rtripault
Copy link
Collaborator Author

After thinking a bit further about this, i believe the "core" should not provide such tool, leaving the room open for multiple players to develop their own CLI tools (the core team have enough work focusing only on the existing/upcoming core code).

Also, i never saw a single issue/feature request, so i would assume the Revo community does not really need such tool.

So closing this proposal

@rtripault rtripault closed this Jan 26, 2017
@matdave
Copy link
Collaborator

matdave commented Apr 7, 2017

After looking into others and reading this I think that even if it's not "shipped" it would be a great asset to have something officially support that was also extensible. It would be great to be able to tie in different automated processes using direct shell commands.

@rtripault
Copy link
Collaborator Author

it would be a great asset to have something officially support that was also extensible

That was my idea too when writing this proposal.

Turns out that the "officially supported" could rather be defined by the community (and adoption of such tool).
But to be fair, i think that's not the kind of tool our community is looking after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants