Remove all not needed 'make sure this is never used' code and logging

modxcms · Sep 10, 2018 · 5ab2ab2 · 5ab2ab2
1 parent 715968d
commit 5ab2ab2
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 24 deletions.
diff --git a/manager/assets/modext/widgets/media/browser.js b/manager/assets/modext/widgets/media/browser.js
@@ -126,8 +126,6 @@ Ext.extend(MODx.Media, Ext.Container, {
     }
 
     ,setReturn: function(el) {
-        // @todo make sure this is never used
-        console.log('MODx.Media#setReturn', el);
         this.returnEl = el;
     }
 

diff --git a/manager/assets/modext/widgets/media/modx.browser.js b/manager/assets/modext/widgets/media/modx.browser.js
@@ -754,8 +754,6 @@ Ext.extend(MODx.browser.Window,Ext.Window,{
     }
 
     ,setReturn: function(el) {
-        // @todo make sure this is never used
-        console.log('MODx.Media#setReturn', el);
         this.returnEl = el;
     }
 
@@ -1111,31 +1109,14 @@ Ext.extend(MODx.Media, Ext.Container, {
     }
 
     ,setReturn: function(el) {
-        // @todo make sure this is never used
-        console.log('MODx.Media#setReturn', el);
         this.returnEl = el;
     }
 
     ,onSelect: function(data) {
-        return false;
-        // @todo make sure this is never used
-        console.log('MODx.Media#onSelect', data);
-        var selNode = this.view.getSelectedNodes()[0];
-        var callback = this.config.onSelect || this.onSelectHandler;
-        var lookup = this.view.lookup;
-        var scope = this.config.scope;
-        this.hide(this.config.animEl || null,function(){
-            if (selNode && callback) {
-                var data = lookup[selNode.id];
-                Ext.callback(callback,scope || this,[data]);
-                this.fireEvent('select',data);
-            }
-        },scope);
+        return;
     }
 
     ,onSelectHandler: function(data) {
-        // @todo make sure this is never used
-        console.log('MODx.Media#onSelectHandler', data);
         Ext.get(this.returnEl).dom.value = unescape(data.url);
     }
 });
@@ -1503,8 +1484,6 @@ Ext.extend(MODx.browser.RTE,Ext.Viewport,{
     }
 
     ,setReturn: function(el) {
-        // @todo make sure this is never used
-        console.log('MODx.Media#setReturn', el);
         this.returnEl = el;
     }