[#2839] Fix bug with failed login count not being updated

modxcms · Nov 22, 2010 · 99fd452 · 99fd452
1 parent 77c27f2
commit 99fd452
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/core/docs/changelog.txt b/core/docs/changelog.txt
@@ -2,6 +2,7 @@
 This file shows the changes in recent releases of MODx. The most current release is usually the
 development release, and is only shown to give an idea of what's currently in the pipeline.
 
+- [#2839] Fix bug with failed login count not being updated
 - Add ability to view permissions inherited when viewing an ACL row in a grid
 - [#2834] Fix issue where constraint class was not set on new FC rules
 - [#2819] Fix issue with FC rules and execution order due to setting default templates, constraints

diff --git a/core/model/modx/processors/security/login.php b/core/model/modx/processors/security/login.php
@@ -136,7 +136,11 @@
 /* check if plugin authenticated the user */
 if (!$rt || (is_array($rt) && !in_array(true, $rt))) {
     /* check user password - local authentication */
-    if($user->get('password') != md5($givenPassword)) {
+    if ($user->get('password') != md5($givenPassword)) {
+        $flc = ((int)$up->get('failedlogincount'))+1;
+        $up->set('failedlogincount',$flc);
+        $up->save();
+
         return $modx->error->failure($modx->lexicon('login_username_password_incorrect'));
     }
 }