Add missing return statement in the package download processor

* origin/pr/12539: Add missing return statement to make sure error is passed back to the user
modxcms · Aug 11, 2015 · b179a76 · b179a76
2 parents 6c07d38 + 4dc7c12
commit b179a76
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/core/docs/changelog.txt b/core/docs/changelog.txt
@@ -4,6 +4,7 @@ development release, and is only shown to give an idea of what's currently in th
 
 MODX Revolution 2.4.0-dev
 ====================================
+- Add missing return statement in the package download processor [#12539]
 - Allow comma-separated list of constraints in Form Customization [#11239]
 - Prevent firing OnDoc*Form* Events on the Resource Overview page [#11865]
 - Automatically select the setup language based on Accept Language headers [#12011]

diff --git a/core/model/modx/processors/workspace/packages/rest/download.class.php b/core/model/modx/processors/workspace/packages/rest/download.class.php
@@ -65,7 +65,7 @@ public function process() {
 
         $this->package = $this->provider->transfer($this->signature, null, array('location' => $this->location));
         if (!$this->package) {
-            $this->failure($this->modx->lexicon('package_download_err_create', array('signature' => $this->signature)));
+            return $this->failure($this->modx->lexicon('package_download_err_create', array('signature' => $this->signature)));
         }
 
         return $this->success('', $this->package);