Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix policy template update #12654

Merged
merged 2 commits into from
Sep 21, 2015
Merged

Conversation

hansek
Copy link
Contributor

@hansek hansek commented Sep 16, 2015

What does it do ?

Added missing update of Policies which using updated Policy template if you remove some of permissions from Policy template.

Why is it needed ?

If you remove "about" permission from AdministratorTemplate, Administrator policy will still have active "about" permission which is wrong.

Related issue(s)/PR(s)

x

E.g.
If you remove "about" permission from AdministratorTemplate
Administrator policy will still have active "about" permission
which is wrong.

Solution
Loop over all Policies using same Policy template and remove those permissions.
@theboxer theboxer added this to the v2.4.1-pl milestone Sep 21, 2015
@theboxer theboxer added bug The issue in the code or project, which should be addressed. area-core labels Sep 21, 2015
@theboxer theboxer merged commit fcd8126 into modxcms:2.4.x Sep 21, 2015
@theboxer theboxer self-assigned this Sep 21, 2015
@hansek hansek deleted the fix_policy_template_update branch October 7, 2015 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core bug The issue in the code or project, which should be addressed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants