Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed duplicate element ID #13105

Closed
wants to merge 1 commit into from
Closed

Removed duplicate element ID #13105

wants to merge 1 commit into from

Conversation

rtripault
Copy link
Contributor

What does it do ?

Removes a duplicated HTML element ID

Why is it needed ?

On system settings manager page, 2 different buttons share the same ID

Steps to reproduce issue

  • navigate to ?a=system/settings
  • activate system events tab
  • get back to system setting tab
  • notice 2 clear filters buttons are displayed

@Jako Jako added type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript. bug The issue in the code or project, which should be addressed. priority-2-high labels Aug 28, 2016
@Jako
Copy link
Collaborator

Jako commented Sep 5, 2016

Merged into 2.5.x

@Jako Jako closed this Sep 5, 2016
@Jako Jako added this to the v2.5.2 milestone Sep 5, 2016
@Jako
Copy link
Collaborator

Jako commented Sep 5, 2016

Thanks!

@rtripault rtripault deleted the duplicate-btn-id branch September 16, 2016 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug The issue in the code or project, which should be addressed. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.
Projects
None yet
Milestone
v2.5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@rtripault @Jako