System/Context settings

[Oetzie]

Summary

The configuration widget from the dashboard does not check the 'site_start' and 'error_page' at context level. This is also a bug with the resource remove processor?.

Step to reproduce

Duplicate the home page of the web context, change the 'site_start' context setting to the new ID. Delete the old homepage and an error like 'Your site start does not exists' will appear in the configuration widget.

Expected behavior

The context settings needs to overrule the system settings.

Environment

MODX version 2.5.8

[OptimusCrime]

I think the consensus is that the default settings should be in the system settings. You can override the settings individually in the contexts, but the system settings should contain valid default values.

If I understood the issue correctly?

[OptimusCrime]

Ping @Oetzie

[Oetzie]

Sorry for the late reply. But why should the systems settings contain valid default values? I override them at context level. So in that cause the system settings aren't needed any more.

[Mark-H]

It can still be fallen back to in contexts that don't have it specifically set.

[OptimusCrime]

You would usually not need to specify the site_start as a context setting for the default context (web). This is also the case for almost every other setting that interacts with specific contexts. I think this is intended behavior.

[Ibochkarev]

@alroniks @JoshuaLuckers this fix was merged in #14108 .

Please close issue.

[Jako]

The configuration widget should check all contexts for site_start/error_page.

The other part (message when deleting the page targeted by the site_start system setting) should be an intended behavior.

[JoshuaLuckers]

Context settings are not taken into consideration in various functionalities like checks that prevent deleting the resource marked as site_start. I was able to set site_start to an empty value in system settings. The web context did have the site_start value and was not checked.