-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent an infinite loop in sendErrorPage() #14108
Conversation
… to redirect in an infinite loop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
elseif
instead of else if
I've tested this PR @JoshuaLuckers. When the Just to confirm, it doesn't redirect to |
I'll check this today #modxbughunt |
Checked, works fine. Thanks! |
Merge remote-tracking branch 'upstream/pr/14108' into 2.x * upstream/pr/14108: Documentation for the new parameter All control keywords should look like single words If the defined error_page is a non-existent resource we don't want it to redirect in an infinite loop
What does it do?
It makes it possible to skip the
sendErrorPage
if the resource does not exist.Why is it needed?
To prevent an infinite loop if the defined
error_page
in system settings is a non-existent resource.Related issue(s)/PR(s)
#14107