Fixing Double-click of image in Media Browser goes to blank page #14076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this PR and it works as described. |
|
I really don’t know where it was used, so yes. |
alroniks
suggested changes
Sep 7, 2018
| @@ -1117,6 +1117,7 @@ Ext.extend(MODx.Media, Ext.Container, { | |||
| } | |||
|
|
|||
| ,onSelect: function(data) { | |||
| return false; | |||
| // @todo make sure this is never used | |||
| console.log('MODx.Media#onSelect', data); | |||
There was a problem hiding this comment.
I guess console.log call should be definitely removed.
|
I have removed all not needed 'make sure this is never used' code and the logging in those methods. The only part where a double click in the media browser leads to an action still works (doubleclick a file during editing a file selecting template variable or a file insert in the RTE). I did not find another place where the double click is used. |
Jako
added
type-frontend
|
Works as expected. Tested in latest versions of firefox/chrome/safari and edge. |
gpsietzema
added
pr/ready-for-merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Make sure that MODx.Media.onSelect code is not executed by removing the code.
Why is it needed?
MODx.Media.onSelect has hidden
this.config.animEl || nullbefore, which means that MODx.Media is hidden accidentally. That way a double-click of an image in the Media Browser goes to blank page.Related issue(s)/PR(s)
#14075