Fixed bug for checking the table prefix while installing MODX #14543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…doesn't disappear after changing the table prefix while installing MODX
|
Thanks for taking time to submit this PR and help make MODX better. Since you are a first-time contributor; please sign the the Contributor License Agreement (CLA). |
JoshuaLuckers
added
the
blocked
Hi Joshua, I've submitted the form twice or even more... Not really sure if it works because I haven't received any confirmation on those submissions. Btw, looks like the link to the CLA form was broken after the last update of modx.com website. I've been given the links to this form https://modx.com/community/contribute/cla/ in the Telegram channel of Russian MODX Contributors. |
JoshuaLuckers
added
pr/review-needed
Mark-H
approved these changes
Apr 25, 2019
JoshuaLuckers
approved these changes
May 4, 2019
JoshuaLuckers
added
pr/ready-for-merging
alroniks
added a commit
that referenced
this pull request
Jun 26, 2019
* upstream/pr/14543: Fixed issue #10760: The message "Table prefix already in use" doesn't disappear after changing the table prefix while installing MODX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It fixes the bug: The message "Table prefix already in use" doesn't disappear after changing the table prefix while installing MODX
Why is it needed?
If the message "Table prefix already in use" appears and you change the table prefix, and click again on the link "Create or test selection", then the old value is still being used.
Related issue(s)/PR(s)
Issue #10760