Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-sass to a version that supports macOS Catalina #14789

Merged
merged 1 commit into from
Oct 26, 2019

Conversation

JoshuaLuckers
Copy link
Contributor

What does it do?

Update node-sass to a version that supports macOS Catalina

Why is it needed?

To make it possible to run grunt build on macOS Catalina.

Related issue(s)/PR(s)

None

@JoshuaLuckers JoshuaLuckers added the pr/review-needed Pull request requires review and testing. label Oct 15, 2019
@JoshuaLuckers
Copy link
Contributor Author

After merging we shouldn't forget to apply this on 3.x as well.

@Mark-H Mark-H added pr/ready-for-merging Pull request reviewed and tested and ready for merging. and removed pr/review-needed Pull request requires review and testing. labels Oct 15, 2019
@JoshuaLuckers JoshuaLuckers self-assigned this Oct 16, 2019
@opengeek
Copy link
Member

I'm confused. I have been running the existing grunt build on Catalina for 3.x without any problems.

@JoshuaLuckers
Copy link
Contributor Author

I'm confused. I have been running the existing grunt build on Catalina for 3.x without any problems.

Steps to reproduce on my machine:

  • cd _build/templates/default
  • rm -rf node_modules
  • npm install

This results in NPM to fail installing node-sass. Before removing the node_modules directory running grunt build would result in:

Error: Node Sass does not yet support your current environment: OS X 64-bit with Unsupported runtime (72)

@JoshuaLuckers JoshuaLuckers merged commit c8dc888 into modxcms:2.x Oct 26, 2019
@Jako
Copy link
Collaborator

Jako commented Oct 26, 2019

Next time please try npm rebuild node-sass before updating node-sass.

@JoshuaLuckers
Copy link
Contributor Author

I did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/ready-for-merging Pull request reviewed and tested and ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants