Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Breaking extras with CMPs #14796

Closed
theboxer opened this issue Oct 16, 2019 · 1 comment
Closed

[3.x] Breaking extras with CMPs #14796

theboxer opened this issue Oct 16, 2019 · 1 comment

Comments

@theboxer
Copy link
Member

I've tested few extras (all had custom manager pages) and none of them worked out of the box.

Changes required for making them work were easy - all needed to fix processors that were extending abstract mod*Processor and add the namespace to the extended processor; adjust the namespace for modExtraManagerController. After those changed everything (usually) started to work as expected.

This might be solve with aliasing abstract classes:

  • modExtraManagerController
  • mod*Processor

Other class worth of aliasing might be modResource as its filterPathSegment method is commonly used.

@Mark-H
Copy link
Collaborator

Mark-H commented Oct 16, 2019

Mark-H added a commit that referenced this issue Nov 1, 2019
…anagerController and modResource classes [#14796]

Merge remote-tracking branch 'upstream/pr/14797' into 3.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants