Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File browser not opening folders with special chars #15328

Closed
ezrarieben opened this issue Nov 10, 2020 · 10 comments
Closed

File browser not opening folders with special chars #15328

ezrarieben opened this issue Nov 10, 2020 · 10 comments
Labels
bug The issue in the code or project, which should be addressed.

Comments

@ezrarieben
Copy link

ezrarieben commented Nov 10, 2020

Bug report

Summary

When trying to open a folder within MODX's file browser that contains one of the following special chars:

  • ä
  • ö
  • ü

The folder does not expand and there is no hover effect on mouseover.

Step to reproduce

  1. Create a folder named "Porträt" using the MODX file manager .
  2. Place a test file in the folder using FTP or another type of directory access (not using MODX).
  3. Refresh the file manager in MODX and try to expand the folder "Porträt".

Observed behavior

Any folder with a special char (out of the list above) in it's name does not expand and has no hover effect on mouseover.

Expected behavior

The folder should expand, the files within the folder should be visible and the hover effect should be visible.

Related issue(s)/PR(s)

N/A

Environment

  • MODX: 2.8.1
  • Apache: 2.4
  • MySQL: 5.7
  • Browser: Edge (Version 86.0.622.51) / Chrome (Version 86.0.4240.193)
@Askalab
Copy link

Askalab commented Nov 10, 2020

I have exactly the same issue with French chars : "éèàêâùô"...

So : any "non-english" char !

@Ruslan-Aleev
Copy link
Collaborator

Ruslan-Aleev commented Nov 13, 2020

Related with #15271 & #14264 & #12932 & #13412
Posibly related with #14320 & #13855 & #15682 & #14508

@rthrash
Copy link
Member

rthrash commented Feb 24, 2021

This issue has been mentioned on MODX Community. There might be relevant details there:

https://community.modx.com/t/filemanager-cant-load-folders-with-umlauts-in-2-8/3698/1

@Ibochkarev
Copy link
Collaborator

Fixed #15505

@frischnetz
Copy link

I don't think, this is resolved in 2.8.3, yet. I still have the same issues with umlauts in file/folder names.

In https://community.modx.com/t/filemanager-cant-load-folders-with-umlauts-in-2-8/3698/1 it was suggested to remove line 65 from core/model/modx/processors/browser/directory/getlist.class.php:

$item['id'] = htmlentities($item['id'], ENT_QUOTES, 'UTF-8');

When I try this for testing purposes, this issue is indeed resolved. But I doubt that this is the best solution.

@rthrash
Copy link
Member

rthrash commented Sep 22, 2021

This issue has been mentioned on MODX Community. There might be relevant details there:

https://community.modx.com/t/directory-content-not-displayed-in-manager-filesystem-tab/4426/2

@frischnetz
Copy link

Dear @rthrash, This discussion you mention links back to this issue.

And as I have described, the issue has not been fixed as far as I see. On a number of websites with version 2.8.3 where umlaut-filenames never made problems before, they now dissappear from the manager. I would appreciate it if you check if for yourself.

@Mark-H
Copy link
Collaborator

Mark-H commented Sep 22, 2021

Ryan's a bot that automatically posts when an issue is mentioned on the forum. ;)

@Mark-H Mark-H reopened this Sep 22, 2021
@Ruslan-Aleev Ruslan-Aleev added the bug The issue in the code or project, which should be addressed. label Feb 4, 2022
@webinmd
Copy link
Contributor

webinmd commented Feb 22, 2022

set system setting
locale = en_US.UTF-8

@smg6511
Copy link
Collaborator

smg6511 commented Oct 2, 2023

Folks, I'm taking a look at this on 2.8.5 and it seems to no longer be an issue. (Note that in my environment, the locale system settings is not set.) I'm going to close this, but if anyone can reproduce this in the current 2.x version (2.8.6 as of now) feel free to re-open.

@smg6511 smg6511 closed this as completed Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue in the code or project, which should be addressed.
Projects
None yet
Development

No branches or pull requests

9 participants