Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with special chars in the directory or file names #15505

Merged
merged 3 commits into from
Mar 15, 2021
Merged

Fix bug with special chars in the directory or file names #15505

merged 3 commits into from
Mar 15, 2021

Conversation

sergant210
Copy link
Collaborator

@sergant210 sergant210 commented Mar 6, 2021 •
edited
Loading

What does it do?

Fixed bug with incorrect display of files or directories in the file tree if the name contains special chars and "+" symbol.

Why is it needed?

The file manager works incorrect.

How to test

  1. Open file manager.
  2. Create a folder named "Porträt" or "+Portrait" using the MODX file manager .
  3. Place a test file in the folder using FTP or another type of directory access (not using MODX).
  4. Refresh the file manager in MODX and try to expand the folder "Porträt".

Related issue(s)/PR(s)

#15271, #15328, #15508

@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Mar 6, 2021
@Ibochkarev Ibochkarev added this to the v2.8.2 milestone Mar 6, 2021
@Ibochkarev Ibochkarev added pr/port-to-3 Pull request has to be ported to 3.x. pr/review-needed Pull request requires review and testing. labels Mar 6, 2021
@sergant210 sergant210 marked this pull request as draft March 6, 2021 15:08
@sergant210
Fixed bug with incorrect display of files or directories in the file …
ad0b27d 
…tree if the name contains special chars or +.
@sergant210 sergant210 marked this pull request as ready for review March 7, 2021 07:43
@Ibochkarev Ibochkarev removed the pr/port-to-3 Pull request has to be ported to 3.x. label Mar 7, 2021
alroniks
alroniks approved these changes Mar 9, 2021
View reviewed changes
Copy link
Collaborator

@alroniks alroniks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works.

@opengeek opengeek merged commit 1fe45d5 into modxcms:2.x Mar 15, 2021
@Ibochkarev Ibochkarev removed the pr/review-needed Pull request requires review and testing. label Mar 15, 2021
This was referenced Mar 15, 2021
Closed
Closed
@Ruslan-Aleev Ruslan-Aleev added the pr/port-to-3 Pull request has to be ported to 3.x. label Mar 15, 2021
@alroniks alroniks mentioned this pull request Mar 30, 2021
Open
This was referenced May 5, 2021
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alroniks alroniks alroniks approved these changes

@Mark-H Mark-H Awaiting requested review from Mark-H Mark-H is a code owner

@opengeek opengeek Awaiting requested review from opengeek opengeek is a code owner

Assignees
No one assigned
Labels
cla-signed CLA confirmed for contributors to this PR. pr/port-to-3 Pull request has to be ported to 3.x.
Projects
None yet
Milestone
v2.8.2
Development

Successfully merging this pull request may close these issues.
5 participants
@sergant210 @alroniks @opengeek @Ibochkarev @Ruslan-Aleev