Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category rank updates only after a reload of the page #15580

Closed
JoePetts opened this issue Mar 23, 2021 · 5 comments · Fixed by #15956
Closed

Category rank updates only after a reload of the page #15580

JoePetts opened this issue Mar 23, 2021 · 5 comments · Fixed by #15956
Assignees
Labels
bug The issue in the code or project, which should be addressed. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.

Comments

@JoePetts
Copy link

Bug report

Summary

If you rewrite the rank of the category, it will be updated only after reloading the page.

Step to reproduce

Right click on the category, rename, rewrite rank value, save.

Observed behavior

If you right-click on the category again and go back to rename, the old value is still there, although the new content was transferred to the database.

Expected behavior

Here the new values should be updated automatically.

Environment

MODx Revolution 2.8.1-pl
PHP 7.3
MariaDB

@rthrash
Copy link
Member

rthrash commented Mar 23, 2021

This issue has been mentioned on MODX Community. There might be relevant details there:

https://community.modx.com/t/sort-categories-in-resource/3847/5

@sottwell
Copy link
Contributor

sottwell commented Mar 23, 2021

This is because the Tree is loaded via AJAX, and is not refreshed upon every change in a resource or element. That's what the Refresh icons are for next to each element section.

Screen Shot 2021-03-23 at 17 18 54

@JoePetts
Copy link
Author

JoePetts commented Mar 23, 2021

This issue has been mentioned on MODX Community. There might be relevant details there:

https://community.modx.com/t/sort-categories-in-resource/3847/5
This is my contribution in the community which I also wanted to mention here.

@sottwell
Thanks for the clarification, had hardly used the update so far. Now I know in which cases this is useful.

@sergant210
Copy link
Collaborator

sergant210 commented Mar 24, 2021

I think it's a bug. The changes should be displayed immediately. The category name changes immediately, but the rank still has the old value if you reopen the Rename dialog.

@alroniks alroniks added type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript. bug The issue in the code or project, which should be addressed. labels Apr 9, 2021
@theboxer theboxer self-assigned this Jan 6, 2022
@theboxer theboxer linked a pull request Jan 6, 2022 that will close this issue
@Ibochkarev
Copy link
Collaborator

Fixed #15956

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue in the code or project, which should be addressed. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants