Remove 'import resources' and 'import site' from core #15841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Removes the "Import HTML" and "Import Static Resources" features from the manager, internally represented as import/index and import/resources.
Why is it needed?
These import features are very rarely used and suggestions to remove it from core and instead encourage an extra to be made has not been opposed in several years.
I strongly agree with the sentiment expressed in those topics. This is a pretty much unused and undocumented feature with very little improvement over the years, and would be better off as an extra.
💰 I'm happy to pitch in €100 for someone to take the code removed here, stick it in a functional extra, and release it for future users. If there's a sensible way to adapt it into ImportX I'd also be happy to review that but I'm not sure that'll translate as easily so would likely be a lot more work.
How to test
Build the core, run setup, confirm the rest of the manager is unaffected and the menu items have been removed.
Related issue(s)/PR(s)
Discussed in a few places, including #13199 and #13737.
Fixes #13737.