Fix create tv panel broken by non-English lexicons #15846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root of the problem will be fixed with the next crowdin update, however this tweak makes it more fault tolerant.
opengeek
force-pushed
the
3.x-fix-tv-non-english
branch
from
3aa061c
to
287f53d
Compare
opengeek
changed the title
opengeek
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fix the create tv panel when using a non-english language.
The root of the problem will be fixed with the next crowdin update, however this tweak makes it more fault tolerant.
Why is it needed?
The panel breaks when a certain class isnt found.
How to test
Set to nl, see break, apply fix, confirm in en too.
Related issue(s)/PR(s)
N/a