"Site temporary unavailable" an error occurs during installation with a certain character in the password

[obelov]

Bug report

Summary

About MySQL passwords, contains "\" symbol and incorrect character processing "\"

Step to reproduce

during the installation step in the "MySQL user password" field, enter the password containing the character "\"

Observed behavior

After clicking the "install" button, an error is thrown "Site temporary unavailable"
In the config file "/core/config/config.inc.php" MySQL password contains an extra character "\\"

Expected behavior

a message should appear : "Core installation was successful. Click next to complete the installation process."

Environment

MODX version 3.0.1 Advanced, Apache, MySQL 10.5.16-MariaDB, Firefox 104.0.2

[halftrainedharry]

The problem seems to be this line in the code:

revolution/setup/includes/runner/modinstallrunner.class.php

Lines 170 to 177 in f7bc013

	/**
	* Sanitize MySQL Password before writing to config, escaping '
	* I'm sure there's a better way to do this, but this works for now.
	* Otherwise, we risk fatal PHP errors if the entered Password
	* contains any single quotes as they would escape the string.
	* See GitHub issue 12502 for more information. https://github.com/modxcms/revolution/issues/12502
	*/
	$this->install->settings->settings['database_password'] = addslashes($this->install->settings->settings['database_password']);

I don't think the problem is the double backslash in the config file \\ (as the backslash is an escape character).
I think the problem is that the settings is changed here (to write it correctly to the config file), but this (changed) setting is then later used again in the installation script.

[JoshuaLuckers]

Are you sure the error is related to the password? Is there anything in the MODX and/or PHP error log?