Fix MODX 3 installation for database passwords with backslashes and quotes #16264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Only the value that is written to the config file is escaped, not the value in the code (that is later used to create the database connection).
addslashesis replaced bystr_replacebecause double quotes (") shouldn't be escaped.Why is it needed?
The MODX 3 installation fails at the
action=installstep, when the "Database password" contains a backslash, or a quote and shows a "Site temporarily unavailable." message.How to test
Install MODX 3 with a "Database password" that contains a backslash, single or double quote and make sure the installation runs successfully.
Related issue(s)/PR(s)
Resolves #16261