Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TVs with filebrowser in other contexts #5139

Closed
mschlegel opened this issue Jun 29, 2011 · 2 comments
Closed

TVs with filebrowser in other contexts #5139

mschlegel opened this issue Jun 29, 2011 · 2 comments
Labels
area-core bug The issue in the code or project, which should be addressed.

Comments

@mschlegel
Copy link

mschlegel created Redmine issue ID 5139

My problem was already described here [[http://bugs.modx.com/issues/4785#note-4]]. But since the bug was already closed when I commented I'm afraid that this last comment got lost. I'm still have some problems with the newest git version (except for the TinyMCE problem, which seems gone).

In short, there are two problems:

  1. While the location of the image TV filebrowser is correct, the file TV filebrowser ignores the filemanager_path/url settings (as described in the previous bug report). For me, applying the same modifications done in core/model/modx/processors/element/tv/renders/mgr/input/image.php also to (...)/file.php (commit: 339e489) solves the problem.
  2. The Base Path/URL settings at the image/file TV input options are really useful for me, however context specific assets_path/url or base_path/url settings seem to be ignored when setting these as placeholders within these paths. E.g.:

@base Path: [[++assets_path]]images/
Base Path Relative: No
Base URL [[++assets_url]]images/
Base URL Relative: No@

The filebrowser does not care about assets_path and assets_url settings and displays folder standard for the web context.

@mschlegel
Copy link
Author

mschlegel submitted:

I found a fix that works for me at a first glance. Edited these files:

@core/model/modx/processors/element/tv/renders/mgr/input/image.php
core/model/modx/processors/element/tv/renders/mgr/input/file.php@

and replaced '@$modx->getOption@' by '@$workingContext->getOption@' at lines 27-33, resp. 28-34 of the two files.

If any context specific setting is present, it seems to be respected.

@splittingred
Copy link

splittingred submitted:

Fixed here: 08c721c for Revolution 2.2 only.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core bug The issue in the code or project, which should be addressed.
Projects
None yet
Development

No branches or pull requests

2 participants