-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path in MODx config files #7366
Comments
eprochasson submitted: I modified the template config file and the resolvers for building the transport package to have relative path config files. However, that will conflict with the new setup process (which allow to change paths) as it will always use the default, relative path. I therefore doubt that it can be merged, but in case, it's here. In my opinion, the case where one moves a modx installation to a different server (I typically develop locally then deploy to a remote server with different paths) is way more common than someone having special path needs, but I might be wrong. Commits are available on github, for the resolvers: Thank you ! |
everettg_99 submitted: Yes, simplified configs would be helpful.
if (!defined('MODX_CORE_PATH')) { $modx_core_path= dirname(dirname(__FILE__)).'/'; define('MODX_CORE_PATH', $modx_core_path); } |
Core config now uses relative pathes AFAIK, and pull requests are no more actual, 2.3+ doesn't have _build/resolvers/resolve.connectors.php at all, so suggest closing |
That, or the fact that the question was raised in 2012. |
We just trying to sort out old issues that was imported from redmine |
I would +1 for closing. No longer relevant. |
Also, #9252 is possible duplicate and should be closed too |
This is no longer relevant @modxbot close |
eprochasson created Redmine issue ID 7366
The config files generated by MODx (/config.core.php, /manager/config.core.php, /connectors/config.core.php and /core/config/config.inc.php) includes absolute path.
As it works perfectly with a new install, I assume I'm not the only one who have a local version for development and a live version on a different server, with different config files (because different paths).
Is there a reason to not use automatically generated path in those config files, assuming most of the developer use the standard MODx file structure anyway.
For example, /config.core.php can be:
The text was updated successfully, but these errors were encountered: