Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link tag not found by parser #9846

Closed
modxbot opened this issue Apr 18, 2013 · 2 comments
Closed

Link tag not found by parser #9846

modxbot opened this issue Apr 18, 2013 · 2 comments
Labels
area-core bug The issue in the code or project, which should be addressed.
Milestone
Revolution-2.2.8-pl

Comments

@modxbot
Copy link
Contributor

modxbot commented Apr 18, 2013

aclcarter created Redmine issue ID 9846

In the SQLSRV version of modparser.class.php, class modLinkTag, function 'process' incorrectly passes parameters to modx->findResource the wrong way round. At line 1249 there appears the following:
@$resource = $this->modx->findResource($context, $this->_output);@
This is wrong, the $context parameter should go second.
@opengeek
Copy link
Member

opengeek submitted:

This was not SQLSRV specific...

@opengeek
Copy link
Member

opengeek submitted:

Fixed in 3c183b2

enigmatic-user pushed a commit to enigmatic-user/revolution that referenced this issue Feb 13, 2014
@opengeek
[modxcms#9846] Fix incorrect parameter order passed to findResource
3c183b2
enigmatic-user pushed a commit to enigmatic-user/revolution that referenced this issue Feb 13, 2014
@opengeek
MODX Revolution 2.2.8-pl
b887595 
Merge branch 'release-2.2'

* release-2.2: (21 commits)
  Remove debugging code (Loud Sigh)
  Bump version for 2.2.8-pl
  Fix pass var by ref error in modX::getInstance()
  [modxcms#9450] Prevent non-existent Context initialization
  Bump version for 2.2.8-dev
  Fixed offline problem described in http://tracker.modx.com/issues/6138
  Fixed icon for datefield inline editor in grid
  Fix of wrong icon for datefield in grid toolbar
  [modxcms#9946] - Please see http://tracker.modx.com/issues/9946
  [modxcms#9859] Fix a near infinite recursion loop on TV ouptut filtering
  Revert "Increase width of file and image TVs"
  [modxcms#9901] Fix empty resourceMap in sqlsrv
  [modxcms#9912] Fix length of modResource.uri index
  [modxcms#9846] Fix incorrect parameter order passed to findResource
  [modxcms#9814] Fix cross-context links using link tags
  [modxcms#9896] Reduces time to process TVs
  Refresh file list after file remove
  Fix remove file from root if no folder selected in tree
  Refresh files after upload if no tree folder was selected (root)
  Fix browser listing in root after media source change
  ...
pixelchutes pushed a commit to pixelchutes/revolution that referenced this issue Mar 1, 2014
@opengeek
Merge branch 'release-2.2' into develop
fa82f33 
* release-2.2:
  Bump version for 2.2.8-dev
  Fixed icon for datefield inline editor in grid
  Fix of wrong icon for datefield in grid toolbar
  [modxcms#9946] - Please see http://tracker.modx.com/issues/9946
  Revert "Increase width of file and image TVs"
  [modxcms#9901] Fix empty resourceMap in sqlsrv
  [modxcms#9912] Fix length of modResource.uri index
  [modxcms#9846] Fix incorrect parameter order passed to findResource
  [modxcms#9814] Fix cross-context links using link tags
  Refresh file list after file remove
  Fix remove file from root if no folder selected in tree
  Refresh files after upload if no tree folder was selected (root)
  Fix browser listing in root after media source change
  Translated the new phrases $_lang['setting_cache_alias_map'] and $_lang['setting_cache_alias_map_desc'] in setting.inc.php.

Conflicts:
	core/docs/changelog.txt
	core/docs/version.inc.php
	core/model/schema/modx.mysql.schema.xml
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core bug The issue in the code or project, which should be addressed.
Projects
None yet
Milestone
Revolution-2.2.8-pl
Development

No branches or pull requests
2 participants
@opengeek @modxbot