New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added children to fireAfterUnDeleteEvent event #12229
Added children to fireAfterUnDeleteEvent event #12229
Conversation
Bump, this fix should be rather simple. Does not break anything, just offers extended access. |
Anything to do with this? |
* @return void | ||
*/ | ||
protected function getChildren(modResource $parent) { | ||
$childResources = $parent->getMany('Children'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is correct, as you'll get all children by this, not only those that were un-deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right. I'll take a look at that.
Any update on making it only grab the ones that were undeleted? |
I'll fix it |
You're the awesomest |
This pull request has been mentioned on MODX Community. There might be relevant details there: |
This pull request has been mentioned on MODX Community. There might be relevant details there: |
Fixes #5004