Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of the parser to process 'forgot_login_email' system setting value #12266

Merged
merged 2 commits into from Aug 4, 2015

Conversation

rtripault
Copy link
Contributor

What does it do ?

Make use of the parser to process forgot_login_email system setting value.

Why is it needed ?

To :

  1. ease the edition of the email (ie. chunks might be more convenient)
  2. allow i18n
  3. use additional tags (snippets/chunks/setting...)

To do before merge

  • make sure unsetPlaceholders will not break anything

Related issue(s)/PR(s)

@Mark-H
Copy link
Collaborator

Mark-H commented Jul 11, 2015

Re your to do, I guess unsetPlaceholders could unintentionally remove placeholders set before the handleForgotLogin method that were overwritten. One hack-ish way I've prevented something like that in another project was something along these lines:

$originalPlaceholders = $this->modx->placeholders();
$this->modx->setPlaceholders($placeholders);
$this->modx->getParser()->processElementTags(...);
$this->modx->placeholders = $originalPlaceholders;

@Mark-H Mark-H added this to the v2.4.0-pl milestone Jul 11, 2015
@rtripault
Copy link
Contributor Author

Yes, that would do the trick i guess. Thanks

@rtripault
Copy link
Contributor Author

PR updated using the given recommendation.
Thanks

@Mark-H Mark-H self-assigned this Aug 4, 2015
@Mark-H Mark-H merged commit 33fb29b into modxcms:develop Aug 4, 2015
@Mark-H
Copy link
Collaborator

Mark-H commented Aug 4, 2015

Mucho gracias for a very cool enhancement :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants