Improve Manager Log by adding a filter for class key and item #13005
Conversation
Working to close feature request #13004
adding the search fields to the core processor
Updating core process for feature request #13004
There wasn't a clear choice available for "Item" in the lexicon, so I originally chose "Event ID" as closest match. It seemed confusing, so I dropped it down to just ID
|
Looks good to me. +1 |
|
👍 Nice work! This is awesome. |
|
👍 |
1 similar comment
|
👍 |
Jako
added
area-core
proposal
|
Hey folks, there's a new feature on GitHub where you can 👍 on the first message (or any other message). If you don't mind, using that instead of posting separate messages for each will help keep things less cluttered, especially when there's a feature or fix that needs more discussion or back-and-forth before it is merged ;) Thanks! If you've actually tested a pull request and verified it to be working as expected, that's a great reason to leave a comment saying that rather than just the thumbs up on the first message though. Stuff like that helps integrators to figure out if a pull request is ready to be merged or not. |
| @@ -69,6 +71,8 @@ public function getData() { | |||
| /* check filters */ | |||
| $wa = array(); | |||
| if (!empty($actionType)) { $wa['action:LIKE'] = '%'.$actionType.'%'; } | |||
| if (!empty($classKey)) { $wa['classKey:LIKE'] = '%'.$classKey.'%'; } | |||
There was a problem hiding this comment.
Does this have to be a LIKE? Are there situations where the class key isn't exactly what was chosen?
There was a problem hiding this comment.
Maybe to search snippet instead of modSnippet
There was a problem hiding this comment.
What Jako said, also just keeping with the same search standards of the other fields
Mark-H
changed the title
|
Any reason not to merge this? Should the |
|
The reason i really prefer |
|
I'm in favor of this too |
|
bump |
What does it do?
Adds an option to search by Class Key or Item ID to the manager logs
Why is it needed?
It's incredibly hard to quickly see the history of who updated a specific element
Related issue(s)/PR(s)
Issue #13004