Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update superboxselect.js #13236

Closed
wants to merge 1 commit into from
Closed

Update superboxselect.js #13236

wants to merge 1 commit into from

Conversation

lexsmil
Copy link
Contributor

@lexsmil lexsmil commented Jan 5, 2017

Escape regular expression special characters

What does it do?

Escape regular expression special characters in last query string

Why is it needed?

Solving the problem that occurs when checking for new input values

Escape regular expression special characters
@OptimusCrime
Copy link
Contributor

Mind elaborate on just what

Solving the problem that occurs when checking for new input values

means?

What is a problem (input/output/behavior) that is solved by this PR? Are there any related issues?

Thank you for submitting a PR btw :)

@lexsmil
Copy link
Contributor Author

lexsmil commented Jan 5, 2017

Sorry for my bad english... Correct me please if I'm somewhere wrong.

The problem is that when using superboxselect, adding new item is checked with the items previously added, and if among the previous elements (which have already been successfully added) among the symbols there are symbols *()? and other special characters for regular expressions error occurred when checking the match function.
For example, the string "Hotel ***** when you add the next element after it will generate an error and will not allow you to add more of any 1 item until you remove the "extra" characters.
I could not find a related issue, but the problem encountered in practice. I decided to share the solution, all right?)

@Jako
Copy link
Collaborator

Jako commented Jan 5, 2017

The regex looks fine. Thanks for sharing!

@OptimusCrime
Copy link
Contributor

Looks good, thank you for explaining @lexsmil

@Jako Jako added area-core bug The issue in the code or project, which should be addressed. priority-2-high labels Jan 5, 2017
@Jako Jako self-assigned this Jan 29, 2017
@Jako
Copy link
Collaborator

Jako commented Jan 29, 2017

Merged into 2.x/2.5.x

@Jako Jako closed this Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core bug The issue in the code or project, which should be addressed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants