Fix issue deleting resource from resource groups tree if it is in multiple groups (#12842) #13283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mark-H Tested this and can confirm this is fixed #modxbughunt |
|
This is supposedly merged for 2.5.6 (thanks), so closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds the resource group ID to the ID used in the tree markup.
Why is it needed?
Go to Content > Resource Groups and assign a resource to two different resource groups. Because the ID was solely based on the resource ID, there was an ID conflict that ExtJS can't handle, so anything you try to do is only applied to one of the resource IDs.
By adding in the resource group ID, they have unique IDs again, and everyone's happy. Even ExtJS.
Related issue(s)/PR(s)
Reported in #12842