Fix package update window not working if update button was pressed twice #13985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the update button has been clicked multiple times.
alroniks
previously approved these changes
Jul 11, 2018
Jako
previously approved these changes
Jul 11, 2018
|
Thanks @JoshuaLuckers for this fix. Yes we don't have cycling now, but after double click I can't call update popup again at all, even after reverted installation try. Please check animated gif below:
|
|
Thanks @himurovich for the feedback. I hope it's fixed now. |
…it to open again.
|
@Jako Good suggestion. In this case the window was always forced to open (the window didn't close so it could not be destroyed). I will check if your suggestion is a solution for this problem. |
Jako
approved these changes
Oct 21, 2018
Jako
added
bug
Jako
added
pr/ready-for-merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Don't force the package update window to open to prevent issues when the update button has been clicked multiple times.
Why is it needed?
It's a fix for issue #13982
Related issue(s)/PR(s)
issue #13982