Trash manager #14058
Merged
Trash manager #14058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 23, 2018 11:01
Added lexicon strings.
| $this->success[] = $id; | ||
| } | ||
|
|
||
| // TODO this still has to be discussed: what happens to the children? |
There was a problem hiding this comment.
Issue #11973 might be sort of relevant here
- Trash icon tooltip is updated on resource delete/undelete - Trash icon is clickable now - Pagetitle column tooltip contains some resource informations - Search/Clear works now - Manager controller moved to resource/trash - Lexicon issues - Button hover colors
|
Checked, refactored, working fine. |
Jako
previously approved these changes
Aug 30, 2018
Jako
added
area-core
proposal
|
I also want to do some refactoring in grid component, but right now I have a lack of time. So I removed state |
alroniks
removed
the
pr/ready-for-merging
Mark-H
approved these changes
Nov 2, 2018
Jako
approved these changes
Nov 5, 2018
|
I wanted to improve some in code, fix some smelling places, but it works well and can be merged, all further improvements I can add later. So feel free to merge. I don't want to block a release. |
Jako
added
pr/ready-for-merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See original PR here #13764 for details.
This is rebased version with additional improvements. Original will be closed after finish if work on improvements.
Template build required
The PR needs to run
_build/templates/default/grunt build. Otherwise the hover state of the buttons is not visible and the changes in modx.tree.resource.js are not in the compressed scripts.