Generate sortable tag signature with serialized array values #14689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opengeek
force-pushed
the
improve-getTag
branch
from
87fd2a1
to
cf2ccbb
Compare
|
I look forward to your contribution, @JoshuaLuckers ! LOL! |
|
In all seriousness, I'm not sure there is an easy way to test the array support in this because the default implementation shipped with the core has no way to express a property value as an array. Array property values are something exclusively being done in 3rd party add-ons. I'll see if I can find a way to do this, but I'm afraid it will take some mocking of the parser to emulate something like Fenom or Twig. |
|
I was wondering how I could test this PR, that’s why I suggested a Unit Test. |
opengeek
added a commit
that referenced
this pull request
Sep 17, 2019
Merge remote-tracking branch 'origin/pr/14689' into 3.x * origin/pr/14689: Generate sortable tag signature with serialized array values in modElement
53 tasks
This was referenced Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Improves the tag signature created by
modElement::getTag().Why is it needed?
When using non-default template engines in MODX (for example, the Fenom implementation by @bezumkin) arrays can be passed as properties. When a tag is generated for the element in these cases, the array will be replaced with the hash of a random string (as arrays are not scalar values). This means that element output can not be matched from the element cache since the random string will never match.
This also allows properties to be so sorted so that the cached output can be matched when similar element tags have a different property order.
Related issue(s)/PR(s)
Replaces #14577 targeting 3.x instead of 2.x, and includes changes suggested in my review of that PR.