Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu improvements #15388

Merged
merged 2 commits into from Mar 3, 2021
Merged

Menu improvements #15388

merged 2 commits into from Mar 3, 2021

Conversation

theboxer
Copy link
Member

What does it do?

  • Hides the menu root (Main Menu) - we don't really need it
  • Prevents dropping menu items outside of Main Navigation or User Navigation
  • Prevents dragging/editing/deleting Main Navigation and User Navigation
  • Adds context menu Create Menu on all nodes

Why is it needed?

To prevent menu items from disappearing.

How to test

Play with menus ;)

Related issue(s)/PR(s)

#15386, #15230, #14521

@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Feb 11, 2021
@Ibochkarev Ibochkarev added the pr/review-needed Pull request requires review and testing. label Feb 11, 2021
@Ibochkarev Ibochkarev added this to the v3.0.0-alpha3 milestone Feb 11, 2021
Ruslan-Aleev
Ruslan-Aleev approved these changes Feb 12, 2021
View reviewed changes
Copy link
Collaborator

@Ruslan-Aleev Ruslan-Aleev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it works!

mm

@theboxer theboxer linked an issue Feb 19, 2021 that may be closed by this pull request
MODX3: Menu item sorting does not work #15386
Closed
@opengeek opengeek changed the title [3.x] Menu improvements Menu improvements Feb 23, 2021
Ibochkarev
Ibochkarev approved these changes Feb 23, 2021
View reviewed changes
Copy link
Collaborator

@Ibochkarev Ibochkarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm - it works. Thank you =)

@opengeek opengeek merged commit 730164c into modxcms:3.x Mar 3, 2021
@Ibochkarev Ibochkarev mentioned this pull request Mar 3, 2021
Closed
@theboxer theboxer mentioned this pull request Jan 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishantrop mishantrop mishantrop left review comments

@Ibochkarev Ibochkarev Ibochkarev approved these changes

@Ruslan-Aleev Ruslan-Aleev Ruslan-Aleev approved these changes

@Mark-H Mark-H Awaiting requested review from Mark-H Mark-H is a code owner

@opengeek opengeek Awaiting requested review from opengeek opengeek is a code owner

Assignees
No one assigned
Labels
cla-signed CLA confirmed for contributors to this PR. pr/review-needed Pull request requires review and testing.
Projects
None yet
Milestone
v3.0.0-alpha3
Development

Successfully merging this pull request may close these issues.

MODX3: Menu item sorting does not work
5 participants
@theboxer @Ibochkarev @mishantrop @Ruslan-Aleev @opengeek