User extended properties - fix rendering value #15389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opengeek
changed the title
Ibochkarev
approved these changes
Feb 23, 2021
Ibochkarev
added
pr/ready-for-merging
opengeek
removed
the
pr/ready-for-merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Add
renderItemTextto theMODx.orm.Treethat is returning encoded value. No encoding is needed in the method as it's already encoded before setting thetextproperty on the node.Why is it needed?
<i></i>tags are visible around the value.How to test
Add new extended field to the user. The value should show in italic.
Related issue(s)/PR(s)
#15356