New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the processor permission response error message #15402
Conversation
Also related with - #15344 |
Yes, the JSON will be decoded and the encoded unicode chars will be transformed to readable text. |
I don't typically want to engage in nitpicking textual stuff, but would "Permission 'foo bar' is required for 'action'" be better English? I think "permission denied 'foo' for 'bar'" may give users the impression they have permission 'foo' but that it's not a valid role of sorts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mark-H You are right. Thanks! |
What does it do?
Why is it needed?
It is not easy to detect, which permission is needed for a combobox processor permission error.
Before:
After:
How to test
Add the following code to i.e. core/model/modx/processors/workspace/namespace/getlist.class.php and open the MODX system settings.
In a grid, the message is shown in the empty grid content.
Related issue(s)/PR(s)
#13243, #12568, #15344