Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix country name in the user section is not always displayed #15413

Merged
merged 2 commits into from Feb 26, 2021
Merged

Fix country name in the user section is not always displayed #15413

merged 2 commits into from Feb 26, 2021

Conversation

Jako
Copy link
Collaborator

@Jako Jako commented Feb 24, 2021

What does it do?

  • Add an empty value to the getlist processor, when the processor properties have set combo=1.
  • Remove the default values in the combo and the panel.

Why is it needed?

The country name in the user section is not always displayed after a reload of the page and stays empty even with a value.

How to test

It should be fixed now, but the field value is flickering after load.

Related issue(s)/PR(s)

#14732

@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Feb 24, 2021
@Ibochkarev Ibochkarev added this to the v3.0.0-alpha3 milestone Feb 24, 2021
@Ibochkarev Ibochkarev added the pr/review-needed Pull request requires review and testing. label Feb 24, 2021
@Ruslan-Aleev
Copy link
Collaborator

Ruslan-Aleev commented Feb 24, 2021

Unfortunately, the problem not disappear. The logic behind the bug is not clear. In the gif below, I just refresh the page in the browser:

country

@Jako
Copy link
Collaborator Author

Jako commented Feb 24, 2021

Please make sure that you are using the changed javascript files in the PR.

@Ruslan-Aleev
Copy link
Collaborator

Yes, sorry, I forgot to disable js compression in the settings. Everything now works, as it seems to me:

country_2

@Ibochkarev Ibochkarev added pr/ready-for-merging Pull request reviewed and tested and ready for merging. and removed pr/review-needed Pull request requires review and testing. labels Feb 24, 2021
@opengeek opengeek merged commit c768565 into modxcms:3.x Feb 26, 2021
@rthrash rthrash removed the pr/ready-for-merging Pull request reviewed and tested and ready for merging. label Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA confirmed for contributors to this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants