Patch MagpieRSS for basic use in PHP 8 #15721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opengeek
added
bug
|
Tested and confirmed on PHP8, tho I did send a separate PR to add back some caching behavior for consideration. |
Add 1-hour cache to the dashboard feeds Merge pull request #29 from Mark-H/patch-magpie
Mark-H
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Patch MagpieRSS to work in PHP 8
Why is it needed?
News and Security feeds are currently blank in PHP 8.
How to test
Load the Manager Dashboard in a PHP 8 environment and confirm the News and Security feeds are not blank.
Related issue(s)/PR(s)
Resolves #15712
Note
Though this makes it work for now in PHP 8, it is not an ideal solution because it bypasses MagpieRSS cache features to get around the fact that in PHP 8 you cannot serialize an XMLParser instance.