Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing lexicon key #15931

Merged
merged 2 commits into from Dec 15, 2021
Merged

Added missing lexicon key #15931

merged 2 commits into from Dec 15, 2021

Conversation

Ibochkarev
Copy link
Collaborator

@Ibochkarev Ibochkarev commented Dec 5, 2021 •
edited

What does it do?

Adds a missing lexicon

Why is it needed?

изображение

Related issue(s)/PR(s)

#15930

@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Dec 5, 2021
@Ibochkarev Ibochkarev added this to the v3.0.0-rc1 milestone Dec 5, 2021
@Ibochkarev Ibochkarev added area-lexicons Issues related to translations and lexicons implementation. pr/review-needed Pull request requires review and testing. labels Dec 5, 2021
opengeek
opengeek requested changes Dec 5, 2021
View reviewed changes
Copy link
Member

@opengeek opengeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be modifying any translations by hand. If it is not there, then something is wrong upstream via CrowdIn and needs to be addressed.

@Jako
Copy link
Collaborator

Jako commented Dec 6, 2021 •
edited

@Ibochkarev The string is just added in the wrong lexicon.

@Ibochkarev
Copy link
Collaborator Author

We should not be modifying any translations by hand. If it is not there, then something is wrong upstream via CrowdIn and needs to be addressed.

This section was created in this PR #15885, but the lexicon for the name of the system settings section is omitted.

@opengeek
Copy link
Member

opengeek commented Dec 7, 2021

The lexicon needs to be added to the en/ lexicon, not the bg/. The en/ lexicons are the source and are the only ones that should be edited directly.

@Ibochkarev
Copy link
Collaborator Author

The lexicon needs to be added to the en/ lexicon, not the bg/. The en/ lexicons are the source and are the only ones that should be edited directly.

Sorry, I saw a mistake

@Jako Jako added pr/ready-for-merging Pull request reviewed and tested and ready for merging. and removed pr/review-needed Pull request requires review and testing. labels Dec 14, 2021
@opengeek opengeek merged commit 5993cb9 into modxcms:3.x Dec 15, 2021
@Ibochkarev Ibochkarev mentioned this pull request Dec 16, 2021
Closed
@theboxer theboxer mentioned this pull request Jan 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jako Jako Jako approved these changes

@opengeek opengeek opengeek approved these changes

@Mark-H Mark-H Awaiting requested review from Mark-H Mark-H is a code owner

Assignees
No one assigned
Labels
area-lexicons Issues related to translations and lexicons implementation. cla-signed CLA confirmed for contributors to this PR. pr/ready-for-merging Pull request reviewed and tested and ready for merging.
Projects
None yet
Milestone
v3.0.0-rc1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ibochkarev @Jako @opengeek