Fix Trash Manager infinite loading error #16415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is he doing? Fixes the "infinite list loading" error. Where did this error come from? modxcms#16228 This change causes an error when starting the processor "resource/trash/getlist". How to test Option 1: Delete the document and go to the trash. Then clean it. There will be an "infinite loading" of the list due to an error. Option 2: Go to the shopping cart and click on the "Update list" icon. There will be an "infinite loading" of the list due to an error. Decision It is necessary to return the sorting so that the xPDOQuery object is returned
JoshuaLuckers
added
pr/review-needed
|
Related #16433 |
theboxer
approved these changes
Oct 2, 2023
theboxer
requested changes
Oct 2, 2023
theboxer
approved these changes
Oct 6, 2023
rthrash
added
pr/ready-for-merging
Mark-H
approved these changes
Feb 10, 2024
opengeek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is he doing?
Fixes the "infinite list loading" error.
Where did this error come from?
#16228
This change causes an error when starting the processor "resource/trash/getlist".
How to test
Option 1: Delete the document and go to the trash. Then clean it. There will be an "infinite loading" of the list due to an error. Option 2: Go to the shopping cart and click on the "Update list" icon. There will be an "infinite loading" of the list due to an error.
Decision
It is necessary to return the sorting so that the xPDOQuery object is returned