[2.x] Remove deprecation warning during setup for PHP 8.2 #16482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on MODX Community. There might be relevant details there: https://community.modx.com/t/error-message-on-upgrade-from-modx2-8-5-to-modx2-8-6/7099/2 |
theboxer
approved these changes
Oct 2, 2023
rthrash
added
the
pr/ready-for-merging
Mark-H
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds the property
$configto the class, so not to rely on dynamic properties.Why is it needed?
In PHP 8.2 the deprecation warning
may get shown on screen during the installation.
How to test
Install MODX with PHP 8.2 and
display_errors=Onand verify that the deprecation warning is not shown.Related issue(s)/PR(s)
https://community.modx.com/t/error-message-on-upgrade-from-modx2-8-5-to-modx2-8-6/7099