Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Role Authority Editability #16568

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Open

Conversation

smg6511
Copy link
Collaborator

@smg6511 smg6511 commented May 8, 2024

What does it do?

Add new listener routine to restrict editing based on whether a Role is assigned to an ACL entry. Also:

  1. Adds new UI feedback, both a lock icon (instead of pencil) on hover of authority as well as an alert dialog when double-clicking on locked authority
  2. Ensures authority cannot be deleted in grid editor
  3. Remove pencil icon for cells of non-editable Roles

Why is it needed?

The ability to edit an assigned Role's authority leads to orphaned ACL rules that not longer show up in the manager, yet remain in the database. See the referenced issue below.

How to test

  1. Rebuild template (grunt build) and clear manager and browser caches
  2. Create a few Roles under the Access Control Lists section
  3. Assign at least one Role to any ACL entry of your choice
  4. Verify that the assigned Roles' authority is locked in the Roles grid
  5. Verify that unassigned Roles remain fully editable in the Roles grid (authority is unlocked)

Note

The initial commit contains all substantive changes, while the follow up is just code-style/optimization oriented.

Related issue(s)/PR(s)

Resolves #16565

Ensure authority cannot be changed on assigned Roles
Formatting and code style fixes and optimizations
@smg6511 smg6511 added the requires build Grunt build is required for integration label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires build Grunt build is required for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to a Role’s definition do not carry through to related ACL entries
1 participant