Added the necessary elements that allow the integration of FontAweasome Plugin #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me Plugin ( https://github.com/josh18/TinyMCE-FontAwesome-Plugin.git ) . This edition was described in the issue #37 , tested on a local install but not packaged .
|
Somebody with write access can give a feedback/comment on the pull request? |
Ibochkarev
requested changes
Mar 19, 2019
| "key": "tinymcerte.extendend_valid_elements", | ||
| "value": "\"span[class] i[class]\"" | ||
| },{ | ||
| "key": "tinymcerte.content_css", |
There was a problem hiding this comment.
Good day!
We may update this PR with integration with NPM or upgrade font-awesome?
There was a problem hiding this comment.
@carnevlu Last version: v5.8.0 https://fontawesome.com/start
Please update your PR. Thank you!
|
It seems that the PR won't work anymore with the current implementation. Registering other TinyMCE plugins in the backend should be done with an own plugin. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @theboxer ,
the original source code of the plugin is available https://github.com/josh18/TinyMCE-FontAwesome-Plugin.git
This edition was described in the issue #37 , tested on a local install but not packaged .