Pgsql driver #41
Closed
Pgsql driver #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides baseline support for dependency metadata to be specified and tested against version constraints
Fixes related errors including xPDO::removeObject() errors
modified: xpdo/om/pgsql/xpdomanager.class.php
modified: ../xpdo/om/pgsql/xpdomanager.class.php
…ept bit more complex queries modified: xpdo/om/pgsql/xpdoquery.class.php modified: xpdo/xpdo.class.php
Modified xPDOObject::save() to call xPDOObject_[driver]::save() with pgsql and oci modified: xpdo/om/pgsql/xpdodriver.class.php modified: xpdo/om/pgsql/xpdoobject.class.php modified: xpdo/om/pgsql/xpdoquery.class.php modified: xpdo/om/xpdoobject.class.php modified: xpdo/om/xpdoquery.class.php
Muchos thanks to opengeek modified: xpdo/om/pgsql/xpdoobject.class.php modified: xpdo/om/xpdodriver.class.php modified: xpdo/om/xpdoobject.class.php
Add / Remove index() fixed to support tablename_indexname format modified: xpdo/om/pgsql/xpdomanager.class.php
…e more proofed setup to = more escapes Found these during oci driver testing modified: test/xPDO_ANSI/xPDOQuery/xPDOQuery.php modified: test/xPDO_ANSI/xPDOQuery/xPDOQuery_Limit.php modified: test/xPDO_ANSI/xPDOQuery/xPDOQuery_SortBy.php modified: xpdo/om/pgsql/xpdoobject.class.php modified: xpdo/om/xpdoobject.class.php
Encountering a semi-colon or UNION keyword outside of quoted strings in an xPDOQuery condition triggers an xPDOException and causes the entire xPDOQuery to be effectively invalidated by adding an always false condition to the WHERE clause: 2=1
This problem was introduced in the last commit and will address modxcms/revolution#11203
|
would be nice to have one adapter more =)! just out of interest, would it be possible to make a "flatfile"-storage system with xPDO? E.g. no database with xPDO (yeah, already sounds stupid...so probably not =D)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests pass