Skip to content
This repository has been archived by the owner on Mar 31, 2020. It is now read-only.

Update domain name used for forwarding #24

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Conversation

weelillad
Copy link
Contributor

Current implementation works for mac, but (probably) not for Windows nor Linux. Changing the domain name to one that aligns with what should be docker's intended implementation.

Refer to docker/for-linux#264 for an explanation of what's available for windows and mac, as well as the issue with the same domain name on Linux.

Refer to docker/for-linux#264 for an explanation of what's available for windows and mac, as well as issues with the same domain name on Linux.
Copy link
Contributor

@soedar soedar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@weelillad
Copy link
Contributor Author

What's the status on this PR? It's causing problems on Linux because for some reason docker.for.mac.localhost is valid when called on Linux from within the container:

/ # getent hosts docker.for.mac.localhost
::1               docker.for.mac.localhost  docker.for.mac.localhost
/ # getent hosts host.docker.internal
/ # 

Therefore socat still tries to forward to 127.0.0.1, when the correct IP should be 172.x.x.x.

2 similar comments
@weelillad
Copy link
Contributor Author

What's the status on this PR? It's causing problems on Linux because for some reason docker.for.mac.localhost is valid when called on Linux from within the container:

/ # getent hosts docker.for.mac.localhost
::1               docker.for.mac.localhost  docker.for.mac.localhost
/ # getent hosts host.docker.internal
/ # 

Therefore socat still tries to forward to 127.0.0.1, when the correct IP should be 172.x.x.x.

@weelillad
Copy link
Contributor Author

What's the status on this PR? It's causing problems on Linux because for some reason docker.for.mac.localhost is valid when called on Linux from within the container:

/ # getent hosts docker.for.mac.localhost
::1               docker.for.mac.localhost  docker.for.mac.localhost
/ # getent hosts host.docker.internal
/ # 

Therefore socat still tries to forward to 127.0.0.1, when the correct IP should be 172.x.x.x.

@soedar soedar merged commit 2bcd9f1 into moexmen:master Oct 23, 2018
wongherlung pushed a commit that referenced this pull request Dec 3, 2018
Refer to docker/for-linux#264 for an explanation of what's available for windows and mac, as well as issues with the same domain name on Linux.
wongherlung pushed a commit that referenced this pull request Dec 3, 2018
Refer to docker/for-linux#264 for an explanation of what's available for windows and mac, as well as issues with the same domain name on Linux.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants